|
|
Post by DonTay89 on May 30, 2018 17:36:33 GMT -5
1) yea long press isnt coded yet 2) agreed 3) left edge swiping is intentionally disabled on now playing because it interferes with the gestures and the seekbar 4) is this 2 separate cases where you got the bug? 44 min album straight through (1 through 13) and then again with on completion shuffle? Good to know on #1-3. For #4, it was two separate cases. I just tried to reproduce by listening to a 15-track 17 minute album all the way through and then the 44-minute album, but had no luck. Then, I rearranged several of the upcoming tracks in the queue and played one to completion. It reproduced the bug(!), but I could only get it to happen about 2 out of 5 times. So it seems the bug is related to rearranging the queue and not the length or amount of tracks. Also while trying to reproduce #4, I found another new bug: 5. If I unplug my Nexus 6P while playing a song, the music pauses as if I disconnected a headset. Plugging it back in resumes the song. I've more information on bug #4, the queue playing showing the next/current song, but playing a previous song. I clicked the first track on the Song tab so it would create a new queue and I manually skipped to track 5 and listened to it to completion. When it ended, track 6 showed as now playing, but the audio from track 2 is actually going. Screenshot: imgur.com/a/MyZ7JzuI was just able to reproduce it 3 times: a) Followed the above steps again. b) Followed the above steps, but instead skipped to track 8 and listened to completion. Track 9 should have played, but the audio to 8 repeated. c) In the 17 minute album I listened to in full previously, I tried skipping from the beginning to track 6 and playing it in full. Upon completion, track 7 showed but track 2's audio played. My conclusion is that the issue has something to do with manually skipping tracks, and not rearranging the queue or the length of the queue like I originally thought. -- Nexus 6P, GoneMAD 3.0a1b |
|
|
|
Post by Eckless on May 30, 2018 22:10:06 GMT -5
DonTay89 - I'm thinking the bug regarding skipping tracks you are pointing out is the same bug I saw on page 2 of this thread (about the "Next Track" functionality displaying the right track but playing the wrong track) - do you get the issue you are experiencing when you skip tracks even when not playing in shuffle mode?
|
|
|
|
Post by Eckless on May 30, 2018 22:13:08 GMT -5
Dontay89 - scratch that last post of mine - you aren't using shuffle mode but instead just putting tracks into your queue. I think I'm getting the same bug when listening to albums.
|
|
|
|
Post by GoneMAD on May 30, 2018 22:37:18 GMT -5
Good to know on #1-3. For #4, it was two separate cases. I just tried to reproduce by listening to a 15-track 17 minute album all the way through and then the 44-minute album, but had no luck. Then, I rearranged several of the upcoming tracks in the queue and played one to completion. It reproduced the bug(!), but I could only get it to happen about 2 out of 5 times. So it seems the bug is related to rearranging the queue and not the length or amount of tracks. Also while trying to reproduce #4, I found another new bug: 5. If I unplug my Nexus 6P while playing a song, the music pauses as if I disconnected a headset. Plugging it back in resumes the song. I've more information on bug #4, the queue playing showing the next/current song, but playing a previous song. I clicked the first track on the Song tab so it would create a new queue and I manually skipped to track 5 and listened to it to completion. When it ended, track 6 showed as now playing, but the audio from track 2 is actually going. Screenshot: imgur.com/a/MyZ7JzuI was just able to reproduce it 3 times: a) Followed the above steps again. b) Followed the above steps, but instead skipped to track 8 and listened to completion. Track 9 should have played, but the audio to 8 repeated. c) In the 17 minute album I listened to in full previously, I tried skipping from the beginning to track 6 and playing it in full. Upon completion, track 7 showed but track 2's audio played. My conclusion is that the issue has something to do with manually skipping tracks, and not rearranging the queue or the length of the queue like I originally thought. -- Nexus 6P, GoneMAD 3.0a1b what shows in the notifications and now playing is a bit diff from what the player actually plays internally so i can definitely see them being out of sync. The metadata is just grabbed from whatever is at the current position in the queue on track change, what plays gets set ahead of time due to crossfade / gapless and whatnot. Typically any action that would affect what is up next in the queue would trigger a reload in the audioengine but i would not be surprised if i missed a specific use case. I'll try to recreate it using your steps. Thanks for posting that much detail, it certainly helps |
|
|
|
Post by GoneMAD on May 31, 2018 23:00:13 GMT -5
GMMP 3.0 Alpha 1c (Updated 5/31/18) www.mediafire.com/file/05406y4b3xzxlx6/gmmp-3.0_Alpha_1c-amazon.apk/filemegasee the post here for more information and details on what type of feedback i am looking for gonemadmusicplayer.blogspot.com/2018/05/gmmp-30-alpha-1-released.htmlIf you get crashes: Reproduce the crash then generate a logcat via the instructions here: gonemadmusicplayer.blogspot.com/2014/07/how-to-get-logcat-system-log-to-help.htmlEDIT: Updated to 1c. 3.0 Alpha 1c (2018-05-31): Album art size tweaks should now be applied to all 18:9 devices Adjusted metadata and media button heights in now playing for 18:9 devices Fixed issue with multiple genres and artists where a empty space was placed before the artist or genre name Fixed crash trying to share files on sdcard Caught exceptions thrown by AudioEffect instead of crashing Fixed crash trying to update metadata of a null track Fixed issue with multiple artist tags not be separated Fixed crash on some devices when changing orientation immediately after starting playback Music Service should not get auto shutdown as easily anymore (drawer -> menu will always shut it down however) Track sorting should now factor in Disc Number Fixed a few of the album list sort options Fixed crash related to the changelog Fixed crash when failing to load album art Fixed disappearing media button icons |
|
|
|
Post by Eckless on Jun 1, 2018 17:50:02 GMT -5
Hey there! A couple of random bugs on 1c:
1. The issue "Track sorting should now factor in Disc Number" - I'm not seeing that working yet. If I sort by track number I'm getting disc 1 track 1, disc 2 track 1, disc 1 track 2, disc 2 track 2...
2. Going into "Effects" crashes for me - do you have the logcats you need from this, or would you like me to send you one?
3. Weird error - if you have a track with multiple genres and play it in Android Auto, on the display you get the track name just fine, but below that is the artist listed twice, separated by a comma. (So I get something like "Singularity" on the top row, "Jon Hopkins, Jon Hopkins" on the second row. I don't see the same issue in the player itself ("now playing" is just fine), and I don't see this issue is a track only has one genre.
4. Skipping to the next track - it's been fixed within the player now (thank you!), but gives a weird issue in Android Auto. If you're midway through track "n" and hit next track in Android Auto, it correctly starts playing track "n+1" and shows the metadata for track "n+1". However the scrubber doesn't start at 0:00 - it starts midway through "n+1". Then when track "n+1" finishes correctly, you get track "n+2"'s metadata showing, but the track playing is "n+1".
|
|
|
|
Post by GoneMAD on Jun 1, 2018 23:12:41 GMT -5
i dont have any logcats so send them in. the rest i'll look into. the disc no i never actually tested but just added it to the sorting order and assumed it worked ( since it was left out before )
|
|
|
|
Post by Eckless on Jun 2, 2018 21:14:50 GMT -5
i dont have any logcats so send them in. the rest i'll look into. the disc no i never actually tested but just added it to the sorting order and assumed it worked ( since it was left out before ) I take back what I said about alpha 1c crashing upon going into Effects...it did persist even after uninstalling and reinstalling...but after a full wipe, I no longer have the issue. Thank you! Eckless |
|
|
|
Post by redacted on Jun 5, 2018 3:33:31 GMT -5
Apologies if this has been posted already, but I didn't see it on the Trello.
When selecting an artist or genre, the re-sizing title bar area doesn't match the theme colour. Here's a video:
Otherwise I'm really enjoying the alpha so far!
|
|
|
|
Post by GoneMAD on Jun 5, 2018 7:21:13 GMT -5
Apologies if this has been posted already, but I didn't see it on the Trello. When selecting an artist or genre, the re-sizing title bar area doesn't match the theme colour. Here's a video: Otherwise I'm really enjoying the alpha so far! what device / os version i've seen something similar... but never a completely different color |
|
|
|
Post by redacted on Jun 5, 2018 10:09:57 GMT -5
what device / os version i've seen something similar... but never a completely different color Pixel XL / Android 8.1.0 |
|
|
|
Post by GoneMAD on Jun 5, 2018 19:16:44 GMT -5
1) yea long press isnt coded yet 2) agreed 3) left edge swiping is intentionally disabled on now playing because it interferes with the gestures and the seekbar 4) is this 2 separate cases where you got the bug? 44 min album straight through (1 through 13) and then again with on completion shuffle? Good to know on #1-3. For #4, it was two separate cases. I just tried to reproduce by listening to a 15-track 17 minute album all the way through and then the 44-minute album, but had no luck. Then, I rearranged several of the upcoming tracks in the queue and played one to completion. It reproduced the bug(!), but I could only get it to happen about 2 out of 5 times. So it seems the bug is related to rearranging the queue and not the length or amount of tracks. Also while trying to reproduce #4, I found another new bug: 5. If I unplug my Nexus 6P while playing a song, the music pauses as if I disconnected a headset. Plugging it back in resumes the song. #5 was actually a newer feature that i accidentally had enabled by default. Hdmi and power plug in / out now work with the auto play/pause. I just dont have a UI yet to configure that so i intended it to be often. Will be fixed in the next patch |
|
|
|
Post by GoneMAD on Jun 5, 2018 21:36:58 GMT -5
For the issue of it playing a different song from what metadata is showing.. has this been an issue with 1c + wiping the app data and rescanning if you have multi genre or artist? Multi genre / artist while it was still bugged would mess up the queue a bit.
I tried recreating the issue and cannot do it. Every queue modification i made, the correct track gets loaded by the audioengine to play next (gmmp logs out the preloads of the next track)
|
|
|
|
Post by DonTay89 on Jun 6, 2018 13:05:02 GMT -5
For the issue of it playing a different song from what metadata is showing.. has this been an issue with 1c + wiping the app data and rescanning if you have multi genre or artist? Multi genre / artist while it was still bugged would mess up the queue a bit. I tried recreating the issue and cannot do it. Every queue modification i made, the correct track gets loaded by the audioengine to play next (gmmp logs out the preloads of the next track) Ok, I just tried your suggestions 4 times and this is what happened. 1. I changed to the dark theme, disabled crossfade and enabled ReplayGain, then tried replicating. BUG EXISTS. 2. Wiped and scanned, but left default settings before trying to replicate. NO BUG. 3. Repeated #2 again. NO BUG. 4. Disabled crossfade and enabled ReplayGain. BUG EXISTS. 5. Disabled crossfade AND ReplayGain. BUG EXISTS. It seems that crossfade being active "fixes" the bug. Can you reproduce if you disable it? |
|
|
|
Post by GoneMAD on Jun 6, 2018 14:17:08 GMT -5
For the issue of it playing a different song from what metadata is showing.. has this been an issue with 1c + wiping the app data and rescanning if you have multi genre or artist? Multi genre / artist while it was still bugged would mess up the queue a bit. I tried recreating the issue and cannot do it. Every queue modification i made, the correct track gets loaded by the audioengine to play next (gmmp logs out the preloads of the next track) Ok, I just tried your suggestions 4 times and this is what happened. 1. I changed to the dark theme, disabled crossfade and enabled ReplayGain, then tried replicating. BUG EXISTS. 2. Wiped and scanned, but left default settings before trying to replicate. NO BUG. 3. Repeated #2 again. NO BUG. 4. Disabled crossfade and enabled ReplayGain. BUG EXISTS. 5. Disabled crossfade AND ReplayGain. BUG EXISTS. It seems that crossfade being active "fixes" the bug. Can you reproduce if you disable it? Thats probably the key. Crossfade vs no crossfade definitely takes different code paths when changing tracks. I'll try without crossfade. Thanks! |
|
