|
|
Post by eckless on Sept 4, 2018 17:53:56 GMT -5
I don't know if it's "screen off" - for me it happens frequently if I'm in another app when the track is changing in the background.
|
|
|
|
Post by GoneMAD on Sept 5, 2018 9:11:53 GMT -5
Ok. That's essentially the same thing code wise
|
|
|
|
Post by nolan2112 on Sept 8, 2018 7:22:58 GMT -5
I do not understand why release version 3? It does not carry any new functionality, hi-res does not support sound output, with the covers a problem. What for ?
|
|
|
|
Post by GoneMAD on Sept 8, 2018 9:29:37 GMT -5
I do not understand why release version 3? It does not carry any new functionality, hi-res does not support sound output, with the covers a problem. What for ? Because I want to. Android development is a hobby to me. I do not make a living on this app and don't really have to justify any of my actions. Maintaining 2.x is a chore. I wrote a pretty long write up in my blog with reasons when I first announced 3.0 |
|
|
|
Post by nolan2112 on Sept 10, 2018 9:33:13 GMT -5
Well, keep your hobby with you. You're not doing this for thank you.
|
|
|
|
Post by nolan2112 on Sept 10, 2018 9:33:26 GMT -5
Well, keep your hobby with you. You're not doing this for thank you.
|
|
Pango
New Member
Posts: 1
|
Post by Pango on Sept 13, 2018 4:05:47 GMT -5
I've just discovered this great player, and I'm really enjoying it, the interface in particular. I also appreciate it that there are no trackers, this should be a major selling point. It's been working flawlessly for me on Android 8.1 (LineageOS 15.1) for the past couple of hours, no crashes so far. Your "alpha" is better than some nominally "stable" releases out there. The only non-trivial issue I've noticed is with BT A2DP playback auto-resume. If it stopped, e.g. because the receiver is powered off, when it comes back online, playback will restart automatically, however it will be through the phone's internal speaker. From a forum search, this issue was mentioned before (with regard to version 2 I think), and this was the answer at the time: if you have the auto resume and always resume settings off and its still auto playing then that means your BT receiver is sending a command to play to gmmp. You could disable the remote controls but that would also cause anythign else thats remotely trying to control the music to not work However, the same does not happen with another player I checked. Then, the following workaround was posted: I found an app to disable that (bluetooth connect and play). Gonna test it. It, sort of, works but is suboptimal because it cannot prevent the playback from starting in the first place, so music will still be heard for a split second before it stops. Playback also resumes automatically for me when I plug in the earphones but then it is through them, not the speaker. I think this issue will only surface in certain Android versions/builds but it could really be addressed at the player level with some control in the Settings whether to resume playback in such situations or not. This is also how the other players handle it, I believe. Personally, I would prefer for the playback to never resume automatically but if the output was via BT or through the headset, then at the very least it should never resume through the phone speaker. If you wanted to look into this, perhaps this is a good starting point that mentions what options are available to control it: stackoverflow.com/questions/29609557/Just a couple of other, really minor things I noticed: 1. Library → Album Artists tab should be hidden if Settings → Scanner → Ignore Album Artist tag is on, also ignore Album Artists in search results. 2. In the Folders view, files that do not have the track number set are all prefixed with "0. "; just showing track titles should be enough in such case. 3. In the Now Playing view, cover is not updated if songs changed while the device was asleep. I think this was mentioned before in this thread by @helmut. 4. Format string not substituted with value in: Settings → Bookmarks → Bookmark tracks longer than %1$d minutes(It could just be removed from the string as the value is already shown to the right.) 5. Capitalization needs fixing in: - Settings → General → Enable scrobbling with scrobble droid
- Settings → General → Enable scrobbling with simple lastfm scrobbler
6. I noticed you consistently use Title Case for all settings. These are the only four that do not follow the rule, if you want to change them: - Settings → Scanner → Rescan files
- Settings → Scanner → Ignore folders with .nomedia
- Settings → Scanner → Format artist/album tags
- Settings → Scanner → Ignore AlbumArtist tag
I read the disclaimer about no feature requests but as a small enhancement you could also consider an ✕ button or some other way to close player from status bar notification, if it's been set not to do so automatically when playback stops. Unless there is already a way to do it and I just don't know about it. Also, not directly related to the alpha version but perhaps not worth it to start another thread just for this: when I buy the unlocker directly from you, I understand Google Play services are not required on the device for it to work, can you confirm this? |
|
|
|
Post by GoneMAD on Sept 13, 2018 7:38:40 GMT -5
its the operating systems job to properly route the audio, gmmp resuming on A2DP connection is what is supposed to happen, but its the OS's job to actually send it over BT. Sounds like an issue with your phone on why its coming out the speaker (prehaps it resumes too fast and the phone itself doesnt change the routing because of that but the majority of phones never have an issue). Individual auto pause / auto resume for different connection types (wired, bt, usb, etc) is planned.. its already in the code i just dont have a settings UI for it yet. Also comparing auto resume to another player is not really valid as gmmp's auto resume is not the same as all other players. In gmmp if you pause via auto pause, it will resume when you connect again (wired, bt, usb, etc). Turn off auto resume in the settings (might be in advanced only? i thought i had that in regular settings to) if this is not the desired behavior (as i said this will be able to be customized by connection in the future.. similar to 2.x). The alpha is mainly for getting base functionality, beta will be a lot more fine tuning and customization As for your other comments 1) All views besides the queue / now playing / settings will be able to be turned off, i just do not have the Settings UI for it yet. 2.x in the holo themes were able to do this. That being said the ignore album artist setting is really only needed if you have trash tags in the album artist field (this was added for a user with bad tags ages ago). If the actual album artist tag is empty, gmmp will populate it with the artist tag by default. Just curious what actually shows up in that tab if you have the ignore album artist setting enabled? 2) All of the list items are just thrown together right now to get something displayable, they will be completely customizable. See the metadata view customization of this blog post for more info on that gonemadmusicplayer.blogspot.com/2017/05/30-work-in-progress-1-new-theme-engine.html . The plan is to provide several premade templates for each view and allow the user to create their own via the markup language i wrote 3) Yea was mentioned earlier, i havent been able to reproduce it. I would imagine its something more device specific (like a race condition that happens in slower phones) since i regularly listen to music with the app in the background and the art changes when i return to the UI.. but this is on a sony xz2 which has an SD845 4) I'm reusing translated strings from 2.x, but i'll see if i can get that populated. All that will be cleaned up in the beta 5) Scrobble Droid and Simple LastFM are proper nouns (names of apps) and should be capitalized 6) Title case maybe used in the majority of the current settings but thats not the case in 2.x. There are a lot more settings that still need to be readded. Those in particular used to be in a completely different UI in the old GMMP days and were moved to be regular settings. As mentioned before i'll eventually do a sweep on all the text (in english at least) and clean things up in the beta Thanks for the feedback! Edit: If you have the auto resume setting off and it is still resuming playback then my quote is valid, your receiver (or your phone) is sending a media intent which is what gmmp is responding to. If auto resume is off it will not do anything on its own. There should be a setting to turn off the remote controls (which will ignore media intents), but this also disables any sort of built in lockscreen controls (notification controls work fine). |
|
|
|
Post by eckless on Sept 14, 2018 19:53:10 GMT -5
A couple of comments to throw out there... 1. I think there's a bug where not all album artists in a genre are shown. From the top level, click on "GENRES". Then in that genre, click on "ALBUMS". That should show the album names and album artist names in that genre. However, there are a few instances when I then go to the "ALBUM ARTISTS" tab that there will be a few that I can see in the "ALBUMS" tab that don't show under "ALBUM ARTISTS". (Said another way, in genre X, I have album Y by album artist Z. If I go to "GENRES" at the top level and then "ALBUMS", I see album Y by album artist Z. But then when I go to the "ALBUM ARTIST" tab within that genre, album artist Z isn't listed.) Note this is pretty inconsistent - I'd say about 1 in 10 won't work correctly for me, and I can't figure out what the common link is between those album artists (some have an album in multiple genres, some have only one genre) 2. Regarding the album art not updating when playing - try this. Play a track from the middle of an album (say #6) and let it play all the way through. Track #7 will start and all is fine. While track #7 is playing, go to the library and pick a song from another album and start playing it. The album art on the "Now Playing" screen will not update to the new album (the text on the "Now Playing" screen does update appropriately, as do the small album art icons at the bottom of the screen and the lockscreen). Thank you - these are pretty obscure, but that what makes finding bugs fun.  Eckless |
|
|
|
Post by Manuel M on Sept 15, 2018 5:52:49 GMT -5
Hello, I have been testing the
app, and I really like the new
interface, the material theme is
much better now. Everything
seems excellent, but I would
like to suggest that they
implement some function to
normalize volume, like
AGC, the "replay gain"
function does not work in the
m4a files, but otherwise, it's
all great. Greetings.
|
|
|
|
Post by GoneMAD on Sept 15, 2018 18:27:33 GMT -5
replaygain works fine for m4a. the audioengine in 2.x is identical to 3.0 and replaygain has always worked fine. Whats the deal with the weird formatting of your post?
|
|
|
|
Post by GoneMAD on Sept 18, 2018 20:27:37 GMT -5
A couple of comments to throw out there... 1. I think there's a bug where not all album artists in a genre are shown. From the top level, click on "GENRES". Then in that genre, click on "ALBUMS". That should show the album names and album artist names in that genre. However, there are a few instances when I then go to the "ALBUM ARTISTS" tab that there will be a few that I can see in the "ALBUMS" tab that don't show under "ALBUM ARTISTS". (Said another way, in genre X, I have album Y by album artist Z. If I go to "GENRES" at the top level and then "ALBUMS", I see album Y by album artist Z. But then when I go to the "ALBUM ARTIST" tab within that genre, album artist Z isn't listed.) Note this is pretty inconsistent - I'd say about 1 in 10 won't work correctly for me, and I can't figure out what the common link is between those album artists (some have an album in multiple genres, some have only one genre) 2. Regarding the album art not updating when playing - try this. Play a track from the middle of an album (say #6) and let it play all the way through. Track #7 will start and all is fine. While track #7 is playing, go to the library and pick a song from another album and start playing it. The album art on the "Now Playing" screen will not update to the new album (the text on the "Now Playing" screen does update appropriately, as do the small album art icons at the bottom of the screen and the lockscreen). Thank you - these are pretty obscure, but that what makes finding bugs fun. Eckless 1) if you can figure out anything consistent in which ones dont show up let me know. I tried reproducing but everything seemed fine with my collection. I dont typically have any multi artist or multi genre so perhaps its related to that (I do tho have plenty of mix / compilation albums with diff album artists than the artists of each tracks) 2) Did the exact steps on a moto e4 and the art updated as expected. Which device are you doing this on? |
|
|
|
Post by NitramAkloh on Sept 20, 2018 2:50:03 GMT -5
Changing the playing speed is only possible in 5 percent steps. It would be nice if 1 percents steps are possible like in the older version 2.x.
|
|
|
|
Post by eserim on Sept 25, 2018 12:41:43 GMT -5
Well after trying loads of players, this is now my new daily player - and I've jumped straight into the Alpha testing - I'll give the player a good thrashing over the next few days - one initial query - hopefully the abaility to ignore "The" at the start of artist name will be included in later builds?
|
|
|
|
Post by GoneMAD on Sept 25, 2018 13:03:46 GMT -5
Well after trying loads of players, this is now my new daily player - and I've jumped straight into the Alpha testing - I'll give the player a good thrashing over the next few days - one initial query - hopefully the abaility to ignore "The" at the start of artist name will be included in later builds? yeah at some point. my focus is on getting all the major functionality in place before readding most of the lesser used features/customizations from 2.x |
|
