WORKING (was:Enqueued songs ignored in random mode

[mcosby]

So I think I'm a fan of GoneMAD, based on what it *seems* it should be able to do, but I've got one annoying bug/feature (I'm not sure if it's a bug or if you just didn't intend the player to work this way) that's causing me problems:

Environment:
Epic CM9 (Ice Cream Sandwich) alpha4
Menu->Preferences->Playlist->On Playlist Completion == "Play Random"
Menu->Preferences->Playlist->Shuffle Mode == "Shuffle Collection"
Menu->Preferences->Playlist->No Repeats == Checked
Menu->Preferences->Library->Song Actions->On Select (stopped) == "Play"
Menu->Preferences->Library->Song Actions->On Select (playing) == "Enqueue"
Menu->Preferences->Library->Song Actions->Queue Album on Song .. == Not Checked

Reproduction steps:
1. start the player on random (e.g. press the "play" button)
2. go to the "song" tab and tap on a song name
3. go to the playlist tab. It shows the currently playing song in white as #1. it shows the song you just enqueued in grey as #2
4. go the "playing" tab and press the "next" button (two arrows with a bar)

Expected results:
the song i enqueued should play, and then it should go back to random mode

Observed Results:
a new random song is played, and the playlist view no longer shows my enqueued songs

Variations/Other tests:
you can substitute "let the current song finish playing" for step 4 and get the same results (it just takes longer, obviously)
i've also tested it by enqueueing multiple songs (basically repeating step 2) and get the same results

Notes:
In step 2 it would be really nice if there were some indication that your song was enqueued beyond the normal click. I'd been playing with poweramp before GoneMAD and it shows a toast stating "enqueued" at that point.

[GoneMAD]

Preferences -> Playlist -> On Playlist Complete -> Play Random

This will let you enqueue tracks.. play a whole album.. do whatever without random kicking in until the last track of the active playlist finishes. You of course want to turn shuffle off

The reason its done this way is because the user shouldnt have to completely clear their playlist in order for shuffle to start up.. (think about if you had 20 songs in the active playlist.. but decided you wanted to shuffle your collection.. they would have to turn on shuffle.. then clear the playlist.. or remove any remaining tracks)

"Notes:
In step 2 it would be really nice if there were some indication that your song was enqueued beyond the normal click. I'd been playing with poweramp before GoneMAD and it shows a toast stating "enqueued" at that point."

I originally had this but it seemed really annoying if you enqueued like 10 tracks really fast.. since it would spam 10 toasts.. each lasting 2 seconds or so. I can look into adding some toasts with an option to turn it off tho

[mcosby]

Thank you for your very fast reply.

The reason its done this way is because the user shouldnt have to completely clear their playlist in order for shuffle to start up.. (think about if you had 20 songs in the active playlist.. but decided you wanted to shuffle your collection.. they would have to turn on shuffle.. then clear the playlist.. or remove any remaining tracks)

I could see how that makes sense if there are songs in the playlist when you turn shuffle on. But I'm adding things to the queue while shuffle is going, and there is at least a bug in the playlist display since the song it says it's going to play next isn't the song it actually plays next.

I know part of the problem is that I use a music player differently than... well, anyone, apparently. But probably 99% of the time when I'm listening to music I don't want to think about my music player at all, because I'm listening to music while I'm working. So my ideal player would stay on shuffle through my entire music collection (with an optional blacklist, but that's a feature request for later) the vast majority of the time. When I wanted to listen to a particular song or groups of songs I could search for them, queue them and they'll play next, and then the system would move right back to shuffle so the music never stops.

With a system like that I only touch my music player to skip the current song if I don't want to hear it, or to search for a specific song that I want to hear. This would let me get my work done while listening to music without constantly fiddling with my phone (which is frowned on at work and inconvenient when I'm exercising or doing woodworking at home).

Anyway, it sounds like this is a combination bug report (enqueued songs *looking* like they'll play but not playing) and feature request (having enqueued songs insert themselves into shuffle without having to keep turning shuffle on and off to play them).

[GoneMAD]

Preferences -> Playlist -> On Playlist Complete -> Play Random

turn that setting on and it will get your intended behavior... just leave shuffle off and it will play through whatever you have enqueued up.. then go back to shuffle

i listen to music the exact same way you do (except i like to play random albums at a time.. which is another choice for on playlist complete)

[mcosby]

That fixed it! Thank you!

I set
Menu->Preferences->Playlist->Shuffle Mode => "Shuffle Off"

and now it does exactly what I want! Thank you! (and... I just bought the unlocker. You can expect a ton of feature requests from me soon, but the player already meets my needs better than any other player for android. Thank you!)

[GoneMAD]

excellent.. yea keep the requests coming.. i will say that MOST of the features that are missing in gmmp right now that are in other players are most likely on my spreadsheet of things to do... but every so often I get a new request that I definitely wouldnt have thought of myself