elgee
New Member
Posts: 40
|
Post by elgee on Jul 1, 2021 15:43:16 GMT -5
I always turn off the Auto Download Artwork and Search Internet settings. I keep a "cover.jpg" file in each album's folder and an "artist_name.jpg" (ie. The_Beatles.jpg) file in each artist's folder. The app sometimes seems to randomly grab an existing album artwork file to use as artist artwork, and I have to manually browse to the artist file in the folder again.
Also, if I restore the app settings from a backup settings.xml, or delete app settings in Android and start over (and turn off those settings again), the app seems not to look in folders first for the artwork and I again have to set artist artwork manually. If I tell the app to scan for artist art, it often fails to find the in-folder files. When I manually set the artwork, the app often does not show the "In Folder" option, even when there is a file there, so I still have to manually set the file.
I would think if Auto Download is turned off, and Search Internet is turned off, that gmmp would automatically show artwork found in artist and album folders (albums don't seem to be a problem), and that if a folder contains a file, the In Folder choice would show. Am I missing something? Does the artist image file need to have a certain name (artist.jpg, etc) to be automatically used?
|
|
|
|
Post by GoneMAD on Jul 1, 2021 16:04:02 GMT -5
|
|
elgee
New Member
Posts: 40
|
Post by elgee on Jul 1, 2021 16:21:16 GMT -5
They're always .jpg files. According to that link, that's the folder structure I'm using, so it should be finding all of them. It's finding some, but for many of them, it's doing step 5.
I noticed for one artist, I already had a .jpg in the artist's folder, but also happened to have different one in gmmp/artistart, and the cached image was used instead of the in folder image. I normally keep the cached folders empty so I know where the images are coming from, but happened to have that single image there when I reset settings today.
For what it's worth, all of my music and image files are on an SD card and not internal storage.
|
|
|
|
Post by GoneMAD on Jul 1, 2021 16:36:01 GMT -5
Do you have an example of an artist's name (as it appears in gmmp's artist list) that doesnt work and the associated image filename? The artist name has to be an exact match.. so i could see that not working 100% of the time. If thats the case, switching to the literal "artist.jpg" should pick things up
also using album art is the fallback if it cannot find any artist images
|
|
elgee
New Member
Posts: 40
|
Post by elgee on Jul 1, 2021 16:58:50 GMT -5
Do you have an example of an artist's name (as it appears in gmmp's artist list) that doesnt work and the associated image filename? The artist name has to be an exact match.. so i could see that not working 100% of the time. If thats the case, switching to the literal "artist.jpg" should pick things up also using album art is the fallback if it cannot find any artist images Ah, that's it. The problem occurs only for artists where I have an "artist sort" or "album artist sort" tag set. My folder names match the sort tag, but my artist image file names do not. I didn't notice that until you mentioned it. So my folder is "/Music/Beatles, The", but the image name is "The Beatles.jpg". This is simply due to how those were originally downloaded. I thought the app just used the first image it found in the artist's folder, so I didn't bother renaming those. I'll start either making an exact match or using "artist.jpg".
I assume your logic is slightly different between checking the artist folder and the cached artistart folder. The one I mentioned earlier where it preferred the cached file was for "Kate Bush.jpg". The two different files had same name, but as I mentioned, the artist's folder is "Bush, Kate".
|
|
elgee
New Member
Posts: 40
|
Post by elgee on Jul 1, 2021 17:19:11 GMT -5
Hmm. Well, I renamed several artist images to "artist.jpg", and I also renamed a couple to match the folder name, "LastName, FirstName.jpg". Re-scanning artist artwork still didn't find them. Also, no "In Folder" option showed up for any of these. I had to manually browse for them again.
Edit: I also tried "folder.jpg", which didn't work either.
|
|
elgee
New Member
Posts: 40
|
Post by elgee on Jul 1, 2021 17:22:35 GMT -5
To clarify my "Ah that's it" reply... the filenames DO match the artist name exactly, but not the artist sort name. And I now realize that it's only artists with sort names set that it fails to find.
|
|
|
|
Post by GoneMAD on Jul 1, 2021 23:09:34 GMT -5
To clarify my "Ah that's it" reply... the filenames DO match the artist name exactly, but not the artist sort name. And I now realize that it's only artists with sort names set that it fails to find. I'll look into that. Seems like you narrowed down the issue. Sounds like the artist search is grabbing the artist sort instead of artist to compare. I'm not totally surprised as a lot of the database access code is shared in various parts of the app |
|
elgee
New Member
Posts: 40
|
Post by elgee on Sept 18, 2021 22:07:27 GMT -5
To clarify my "Ah that's it" reply... the filenames DO match the artist name exactly, but not the artist sort name. And I now realize that it's only artists with sort names set that it fails to find. I'll look into that. Seems like you narrowed down the issue. Sounds like the artist search is grabbing the artist sort instead of artist to compare. I'm not totally surprised as a lot of the database access code is shared in various parts of the app Any chance you've found anything with this issue? |
|
|
|
Post by GoneMAD on Sept 19, 2021 9:23:39 GMT -5
|
|
elgee
New Member
Posts: 40
|
Post by elgee on Sept 19, 2021 11:55:21 GMT -5
Thanks for checking.
From the trello card: "I see nothing in the code to indicate the sort tags are used for art searches".
Yes, that appears to be the problem. It's NOT finding images when the sort tag IS set AND the folder name matches the Sort tag. So my albums for "The Beatles" use "Beatles, The" as both the folder name and sort tag, and images in the folder are not found automatically. To clarify my original posts, I've tried renaming image files to match both the Artist tag and Artist Sort tag, and also tried using "artist.jpg" as the literal name, all with no luck.
|
|
|
|
Post by GoneMAD on Sept 19, 2021 13:39:50 GMT -5
Thanks for checking. From the trello card: "I see nothing in the code to indicate the sort tags are used for art searches". Yes, that appears to be the problem. It's NOT finding images when the sort tag IS set AND the folder name matches the Sort tag. So my albums for "The Beatles" use "Beatles, The" as both the folder name and sort tag, and images in the folder are not found automatically. To clarify my original posts, I've tried renaming image files to match both the Artist tag and Artist Sort tag, and also tried using "artist.jpg" as the literal name, all with no luck.
yea that's not a bug. Folder must match the artist name, not the sort tag gonemadmusicplayer.blogspot.com/p/artwork-priorities.htmlas for the image location.. is in in the artist folder or in with the album? i'd have to check but i think the image name check only applies if its in the folder with the music |
|
|
|
Post by GoneMAD on Sept 19, 2021 15:10:09 GMT -5
Okay yeah if the folder the music is in, or the parent folder does not contain the artist name it is not going to get searched at all for artist art
|
|
elgee
New Member
Posts: 40
|
Post by elgee on Sept 19, 2021 15:35:51 GMT -5
Yeah, my artist image files are in a parent artist folder that also contains all of that artist's albums in their respective folders.
Well that's a bummer. Thanks for verifying.
|
|
|
|
Post by MotleyGord on Sept 19, 2021 16:37:59 GMT -5
Okay yeah if the folder the music is in, or the parent folder does not contain the artist name it is not going to get searched at all for artist art So this explains why 100% of my Albumartist’s in that list have artwork, but in the Artist list only those that match an existing AlbumArtist show up. Even if a manual search is triggered. Any quick suggestions to have the additional artists get artwork when they only exist in a compilation? |
|
