|
|
Post by toonie on Sept 13, 2012 15:09:19 GMT -5
I've just sent you an email as requested. Not sure what to suggest, though your earlier idea of using the Xiph libraries directly seems like the best bet, but probably more work for you. I wish you the best of luck with this. Sadly my Android dev skills don't stretch to handling media at this low a level, so can't offer to help, beyond giving you as detailed a feedback as I can.
Best Wishes,
Toonie.
|
|
|
|
Post by GoneMAD on Sept 13, 2012 16:56:36 GMT -5
i'll probably start with updating the ffmpeg ogg decoder with the trunk of the ffmpeg repo... they have weird releases
gmmp uses 0.6.6 which is actually pretty old plus some more recent bug fixes
"0.6.6 appeared on 2012-06-09. It is the latest point release from the 0.6 release branch, which was cut on 2010-05-04. it includes all changes from libav 0.6.6 as of 2012-06-09. "
0.11.1 is the "latest" release.. so there might be some changes i can bring back to fix things.
There also might be a switch to use the official decoder instead of the custom ffmpeg one (they supported both for awhile i think)
|
|
|
|
Post by toonie on Sept 14, 2012 6:51:52 GMT -5
Really hope you make good progress. Just out of interest, does this problem occur on other phones, or is it just the S2?
Regards,
Toonie.
|
|
|
|
Post by GoneMAD on Sept 14, 2012 8:21:10 GMT -5
yeah it happens on the epic 4g (galaxy s) and the galaxy s3.. i havent tested on my other devices but the portion of code that handles ogg is the same throughout all the devices
|
|
|
|
Post by GoneMAD on Sept 15, 2012 13:53:43 GMT -5
well i have good news and bad news.
bad news: updating ffmpeg to 0.11.1 didnt help anything
good news: i discovered why there is a click and have a work around that removes it.
reason for the click: there was extra silence being added to the end of the track.. how that is happening.. i have no idea
solution: adding silence detection / clipping for files without gapless data seems to do the trick. The first and last few milliseconds of each file is scanned for silence and removes every until non silence is detected. I tested with the ogg files you sent and i did not notice a click anymore. So the next update will have an option to detect and remove silence.. and then a configurable threshold for the silence detection
i'd still like to find out why that silence is being added.. but this should do for now
|
|
|
|
Post by toonie on Sept 16, 2012 2:15:07 GMT -5
Well, it's good to hear you're getting on top of the issue, and look forward to trying out the fruits of your labour. I'm happy to assist in any testing if you'd care to send me an APK file?
Regards,
Toonie
|
|
|
|
Post by GoneMAD on Sept 17, 2012 22:15:32 GMT -5
okay.. yea i can send something your way to test when its done
|
|
|
|
Post by GoneMAD on Oct 16, 2012 3:02:41 GMT -5
so... part of my work for 1.4 is to redo a bunch of the audioengine.. and that involves reevaluating the decoders im using currently. Turns out the ogg decoder is highly inefficient on ARM chips so I been working to switch it to use a decoder called tremor and it does not seem to have that weird gapless glitch present
|
|
|
|
Post by potential customer on Apr 8, 2013 16:21:10 GMT -5
The glitch is still there. Even though the silence remover is on. I'm sad about this, because other things are great and the player aspires to be the best.
|
|
|
|
Post by GoneMAD on Apr 8, 2013 17:28:08 GMT -5
for ogg or opus? the silence removal only gets applied to mp3/m4a
I still havent fixed the opus gapless issue.. its an issue with ffmpeg and that code is a nightmare to go through
|
|
|
|
Post by chromium on Aug 6, 2014 17:55:27 GMT -5
for ogg or opus? the silence removal only gets applied to mp3/m4a I still havent fixed the opus gapless issue.. its an issue with ffmpeg and that code is a nightmare to go through Any progress on the Opus gapless issue. I wanted to convert all of my music to Opus and this looked like the best player to play it with. I got the trial version and did some testing and the gapless play is not seamless for Opus files. It does work fine for Ogg Vorbis. I've already purchased Poweramp so can use that for gapless Ogg Vorbis, would buy GoneMad in a second if it played Opus gapless properly  Cheers. |
|
|
|
Post by GoneMAD on Aug 6, 2014 18:10:13 GMT -5
for ogg or opus? the silence removal only gets applied to mp3/m4a I still havent fixed the opus gapless issue.. its an issue with ffmpeg and that code is a nightmare to go through Any progress on the Opus gapless issue. I wanted to convert all of my music to Opus and this looked like the best player to play it with. I got the trial version and did some testing and the gapless play is not seamless for Opus files. It does work fine for Ogg Vorbis. I've already purchased Poweramp so can use that for gapless Ogg Vorbis, would buy GoneMad in a second if it played Opus gapless properly Cheers. No.. my attempt to update ffmpeg/libopus for 1.6 caused a bunch of playback issues so it was reverted. I dont think that would have fixed the issue anyway.. i will most likely have to implement libopus like most of the other codecs instead of going through ffmpeg. I dont really have this task on my radar anytime soon |
|
|
|
Post by chromium on Aug 6, 2014 20:20:36 GMT -5
That's a shame, the player looks awesome and actually plays Opus, unlike Poweramp I've settled for Ogg Vorbis at 80kbps, both players do gapless perfectly with that. Maybe one day we can get perfect Opus gapless playback. Thanks for the reply.! |
|
|
|
Post by GoneMAD on Aug 6, 2014 20:36:00 GMT -5
That's a shame, the player looks awesome and actually plays Opus, unlike Poweramp I've settled for Ogg Vorbis at 80kbps, both players do gapless perfectly with that. Maybe one day we can get perfect Opus gapless playback. Thanks for the reply.! 80kbps? thats extremely low bitrate. The ogg files i have are averaged around 160kbps but i'd probably make them higher if i ever reripped the albums |
|
|
|
Post by chromium on Aug 6, 2014 22:42:24 GMT -5
That's a shame, the player looks awesome and actually plays Opus, unlike Poweramp I've settled for Ogg Vorbis at 80kbps, both players do gapless perfectly with that. Maybe one day we can get perfect Opus gapless playback. Thanks for the reply.! 80kbps? thats extremely low bitrate. The ogg files i have are averaged around 160kbps but i'd probably make them higher if i ever reripped the albums I'm looking for something low bitrate with decent quality. I use FLAC at home, but on the go space is at a premium. On my iPhone I used AAC-HE at around 64kbps and was happy with the results. I had issues with gapless play and AAC on my Android, so was looking for something else. I wanted to use Opus but if I can't use it with gapless I need something else. Ogg i supposed to be pretty good at 80kbps and comparable to AAC-HE. It also plays gapless with no issues |
|
