|
Post by chamelleon on Apr 24, 2019 6:07:09 GMT -5
Hi, I have a maybe stupid problem but it's frustrating for me. Every time I update "rating" tag in song by clicking stars, "Total Tracks" tag disappears from file. I know that GMMP does not use "Total Tracks" tag but I have mapped library from my PC to my phone and I don't like when something removes tags from my files. Is there any way to fix it? Attachments:
|
|
|
Post by GoneMAD on Apr 24, 2019 8:18:10 GMT -5
so gmmp (at least the code i wrote) does not remove any tag, however all tag reading and writing is handed by another library called taglib. I would guess taglib is losing the tag when converting to the ID3 version it writes out (its either 2.3 or 2.4 and it'll convert the tags to that version).
You should use something like mp3tag to compare the 2 files as it gives much more information about the tags. The extended tags right click option typically shows all the tags closer to their raw form (some metadata can be represented by differnet tags.. ie album artist can either be TPE2 or TXXX Album Artist)
|
|
|
Post by chamelleon on Apr 24, 2019 8:42:20 GMT -5
You're completely right. I didn't notice that. After rating a song it changes tag type to id3v2.4 and default tag type of foorbar2000 is id3v2.3. So all my music is tagged with id3v2.3 because id3v2.4 it less compatible with some players and still not 100% supported by Windows. So, no way to change tag type manually? Attachments:
|
|
|
Post by GoneMAD on Apr 24, 2019 14:04:16 GMT -5
looks like mpeg/mp3 defaults to v2.4 github.com/taglib/taglib/blob/master/taglib/mpeg/mpegfile.cpp#L208I can add something to the request list to be able to specify id3 version but based on the amount of development time i get, its nothing i can look at any time soon. Do you know what tag foobar is using for total tracks? I would not expect it to get stripped when converting to 2.4
|
|
|
Post by chamelleon on Apr 24, 2019 15:25:28 GMT -5
Don't need to rush. I was afraid that it's some bug and tags disappears randomly. It's only one minor tag so if You can do i'll be happy, if You can't I won't be crying until rest of tags stays untouched. I'm pretty sure that foobar2000 is using id3v2.3 as default to tag files. Anyway thank You for chat. Attachments:
|
|
|
Post by GoneMAD on Apr 24, 2019 15:38:47 GMT -5
i just glanced at the id3 spec and i think i know why its happening (its not the 2.3 to 2.4 conversion thats doing it)
"TRCK The 'Track number/Position in set' frame is a numeric string containing the order number of the audio-file on its original recording. This may be extended with a "/" character and a numeric string containing the total numer of tracks/elements on the original recording. E.g. "4/9"."
GMMP treats track number as an integer and not text.. so i believe when it goes to save the track number.. it ends up just writing 4 instead of 4/9 in the example above. Seems stupid on their part to not make a separate tag specifically for total tracks. I dont think i'll be able to fix this until i rework the tagging code to be more generic (read in any tag instead of just the ones i predefined)
|
|